Page 1 of 1

Newsbin 6.82 Build 5142 hangs caused by RarPasswords.txt

PostPosted: Mon Jan 20, 2020 2:29 pm
by nada2k
Hello

After upgrading Newsbin from version 6.81 to 6.82 it startet to hang when trying to download.

After trying several things I think it's caused by my RarPasswords.txt. It contains ~ 1700 passwords. With a new, empty RarPasswords.txt it works fine.

Reverting to Version 6.81 also solved the issue.

Maybe you can have a look if you can reproduce this? I could PM you a header/password example.

Thanks!

Re: Newsbin 6.82 Build 5142 hangs caused by RarPasswords.txt

PostPosted: Mon Jan 20, 2020 3:42 pm
by Calahan
I didn't have the time to report this problem, but I'm fighting with this problem for months.

It doesn't have to be so many passwords. About 100 or 200? are enough to slow down Newsbin and let it hang.
I can see it in the log.
When only a few password are in the list, then this happens in the log for example:
[01/20 13:49:37] DEBUG Encrypted RAR: Password Found: 1bb5.....d5.part35.rar
[01/20 13:49:37] DEBUG Encrypted RAR: Password Found: 1bb5.....d5.part40.rar
[01/20 13:49:37] DEBUG Encrypted RAR: Password Found: 1bb5.....d5.part47.rar
[01/20 13:49:37] DEBUG Encrypted RAR: Password Found: 1bb5.....d5.part38.rar
[01/20 13:49:37] DEBUG Encrypted RAR: Password Found: 1bb5.....d5.part46.rar
[01/20 13:49:37] DEBUG Encrypted RAR: Password Found: 1bb5.....d5.part49.rar
[01/20 13:49:37] DEBUG Encrypted RAR: Password Found: 1bb5.....d5.part45.rar
All seven lines have the same time.

If the password list gets bigger, this happens:
[01/20 13:49:37] DEBUG Encrypted RAR: Password Found: 1bb5.....d5.part35.rar
[01/20 13:49:49] DEBUG Encrypted RAR: Password Found: 1bb5.....d5.part40.rar
[01/20 13:50:01] DEBUG Encrypted RAR: Password Found: 1bb5.....d5.part47.rar
[01/20 13:50:16] DEBUG Encrypted RAR: Password Found: 1bb5.....d5.part38.rar
[01/20 13:50:32] DEBUG Encrypted RAR: Password Found: 1bb5.....d5.part46.rar
[01/20 13:50:45] DEBUG Encrypted RAR: Password Found: 1bb5.....d5.part49.rar
[01/20 13:51:59] DEBUG Encrypted RAR: Password Found: 1bb5.....d5.part45.rar

Over 2 minutes Newsbin hangs. GUI isn't updated and download seems to stop.
At the moment I have to delete all passwords at least every week.

All the best,
Calahan

Re: Newsbin 6.82 Build 5142 hangs caused by RarPasswords.txt

PostPosted: Tue Jan 21, 2020 11:13 am
by Quade
Yeah you have to keep the list trimmed down. These days maybe even having a list is a bad idea. It seems like it's one password per file set so, password re-use is a thing of the past.

I'm probably going to remove the list and change how the whole mechanism works so, you assign a password per download and no list exists.

Re: Newsbin 6.82 Build 5142 hangs caused by RarPasswords.txt

PostPosted: Tue Jan 21, 2020 2:13 pm
by Calahan
I would keep the password list. So it can cointain "some" passwords which are often used. Only managed by the user.
When adding a nzb file with {{password}} it should not be addded to the password list but remembered for the extraction.
If no password was specified but one is needed, the programm could look through the password list as today.

All the best,
Calahan

Re: Newsbin 6.82 Build 5142 hangs caused by RarPasswords.txt

PostPosted: Tue Jan 21, 2020 2:56 pm
by nada2k
I wonder why it's working in version 6.81? I experienced no such issues there at all. Sure, I can just delete passwords from the file, but it's still strange.

Re: Newsbin 6.82 Build 5142 hangs caused by RarPasswords.txt

PostPosted: Tue Jan 21, 2020 6:01 pm
by Quade
I would keep the password list. So it can cointain "some" passwords which are often used. Only managed by the user.


I'll have to implement my idea either way but I think your idea is doable. Never automatically add. Use the list if a password isn't already assigned.

I wonder why it's working in version 6.81? I experienced no such issues there at all. Sure, I can just delete passwords from the file, but it's still strange.


Maybe something as simple as the order the passwords is checked has changed. Having a large password list has always been problematic. The only way Newsbin can tell what password is to use is to try each of them one at a time so, the more you have, the slower it runs.

Re: Newsbin 6.82 Build 5142 hangs caused by RarPasswords.txt

PostPosted: Sun Jul 19, 2020 12:38 pm
by eReMBee
With the annoying habit the last couple of years to password almost each and every upload, the number of passwords indeed are rising rapidly.
I do delete the list regularly, but would also rather see that {{PASSWORD}} are not automatically added. Hopefully that can be realized in v.6.83.

Re: Newsbin 6.82 Build 5142 hangs caused by RarPasswords.txt

PostPosted: Sun Jul 19, 2020 8:16 pm
by Quade
It's already scheduled for change. It might not make the first new beta but it's on my list. I'll leave rarpasswords.txt in there but it's not going to be the primary way. Either manually assigned or {{password}} passwords will only be assigned to the download and won't populate the password list.